Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): add new-department-tag #693

Closed
wants to merge 1 commit into from
Closed

Conversation

anabrook
Copy link
Contributor

What is being delivered?

Add icons:

  • style

What impacts?

  • Icons

@anabrook anabrook self-assigned this Jan 29, 2025
@anabrook anabrook requested a review from felipefialho January 29, 2025 16:57
Copy link

Copy link
Contributor

github-actions bot commented Jan 29, 2025

PR Preview Action v1.6.0
Preview removed because the pull request was closed.
2025-02-05 14:20 UTC

@@ -176,6 +176,7 @@ export type IconProps =
| 'reload'
| 'replay'
| 'search-off'
| 'style'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

n entendi o nome desse ícone... oq é?

Copy link
Contributor Author

@anabrook anabrook Jan 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MayaraRMA eu peguei esse nome do DS do figma

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oq ele representa?

Copy link
Contributor Author

@anabrook anabrook Jan 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MayaraRMA ele seria um icone default para quando entra um departamento novo que não foi mapeado.

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uhmm, the icon's name is a bit weird, is a good idea thinking about it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anabrook Uhmm, I don't know if `style-chart' tells about this icon, could u try to use some tool of AI to analyze it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unmaped-new-departament or new-tag or new-department-tag, something like that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked this new-department-tag, @MayaraRMA. Can we continue with this name?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think yes!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi guys, how are you? I'm going to close a pull request because ux chose to use the truck icon.

image

psc:. @felipefialho @MayaraRMA @gabrielduete

@felipefialho felipefialho changed the title feat(icons): new icon style feat(icons): add new-department-tag Jan 31, 2025
@gabrielduete gabrielduete self-requested a review February 4, 2025 13:01
@felipefialho felipefialho self-requested a review February 4, 2025 22:15
@anabrook
Copy link
Contributor Author

anabrook commented Feb 5, 2025

I'm going to close a pull request because ux chose to use the truck icon.

@anabrook anabrook closed this Feb 5, 2025
@anabrook anabrook deleted the feat/new-icon-style branch February 5, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants